Skip to content

Commit 328833d

Browse files
melvincarvalhomelvincarvalho
authored
fix(cli): forward plugins and appPaths from config to createServer (#592) (#593)
loadConfig merges both keys from config.json, but the explicit createServer allowlist in bin/jss.js omitted them — so the documented 'declare the apps in config' route (#206/#589, docs/configuration.md) silently booted a server with no plugins, exactly the missing-app failure mode the loader was designed to refuse. Same for appPaths (#582). Verified: jss start -c config.json with a plugins entry now mounts the app (route responds, config delivered to activate); before the fix the same config booted with a 404 on the plugin route.
1 parent 7021ab3 commit 328833d

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎bin/jss.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,11 @@ program
268268
mongoUrl: config.mongoUrl,
269269
mongoDatabase: config.mongoDatabase,
270270
mcp: config.mcp,
271+
// Config-file-only keys (no CLI flags yet): omitting them here made
272+
// the documented `-c config.json` route silently boot without the
273+
// declared apps (#592).
274+
appPaths: config.appPaths,
275+
plugins: config.plugins,
271276
});
272277

273278
await server.listen({ port: config.port, host: config.host });

0 commit comments

Comments
 (0)