Fix Windows backslash in Azure blob names

yuseok89 · yuseok89 · commit 507e19c7d413 · 2026-05-17T23:03:48.000+09:00
diff --git a/providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/gcs_to_wasb.py b/providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/gcs_to_wasb.py
@@ -19,7 +19,7 @@
 
 from __future__ import annotations
 
-import os
+import posixpath
 from collections.abc import Sequence
 from typing import TYPE_CHECKING
 
@@ -143,7 +143,7 @@ def _transform_file_path(self, file_path: str) -> str:
         :return: The transformed file path for Azure Blob destination
         """
         if self.flatten_structure:
-            return os.path.basename(file_path)
+            return posixpath.basename(file_path)
         return file_path
 
     @staticmethod
@@ -186,7 +186,7 @@ def execute(self, context: Context) -> list[str]:
 
         blob_prefix = self.blob_prefix
         if not self.keep_directory_structure and self.prefix and not self.flatten_structure:
-            blob_prefix = os.path.join(blob_prefix, self.prefix)
+            blob_prefix = posixpath.join(blob_prefix, self.prefix)
 
         existing_blobs_set: set[str] = set()
         if not self.replace:
@@ -227,7 +227,7 @@ def execute(self, context: Context) -> list[str]:
                     object_name=file, bucket_name=str(self.gcs_bucket), user_project=self.gcp_user_project
                 ) as local_tmp_file:
                     transformed_path = self._transform_file_path(file)
-                    dest_blob = os.path.join(blob_prefix, transformed_path)
+                    dest_blob = posixpath.join(blob_prefix, transformed_path)
                     self.log.info("Saving file from %s to %s", file, dest_blob)
                     wasb_hook.load_file(
                         file_path=local_tmp_file.name,
diff --git a/providers/microsoft/azure/tests/unit/microsoft/azure/transfers/test_gcs_to_wasb.py b/providers/microsoft/azure/tests/unit/microsoft/azure/transfers/test_gcs_to_wasb.py
@@ -18,7 +18,6 @@
 
 from __future__ import annotations
 
-import os
 import sys
 from types import ModuleType
 from unittest import mock
@@ -34,15 +33,6 @@
 GCS_OBJECTS = ["data/a.txt", "data/b.txt"]
 
 
-def _expected_blob_paths(blob_prefix: str, *relative_keys: str) -> list[str]:
-    """Match operator dest_blob construction (os.path.join) with forward slashes for asserts."""
-    return [os.path.join(blob_prefix, key).replace("\\", "/") for key in relative_keys]
-
-
-def _norm_paths(paths: list[str]) -> list[str]:
-    return [p.replace("\\", "/") for p in paths]
-
-
 class TestGCSToAzureBlobStorageOperator:
     def test_init_defaults(self):
         op = GCSToAzureBlobStorageOperator(
@@ -87,12 +77,11 @@ def test_execute_replace_uploads_all(self, mock_gcs_hook, mock_wasb_hook):
         )
         result = op.execute(context=None)
 
-        assert _norm_paths(result) == _expected_blob_paths(BLOB_PREFIX, "data/a.txt", "data/b.txt")
-        mock_wasb_hook.return_value.load_file.assert_called()
+        assert result == [f"{BLOB_PREFIX}/data/a.txt", f"{BLOB_PREFIX}/data/b.txt"]
         assert mock_wasb_hook.return_value.load_file.call_count == 2
         first_kw = mock_wasb_hook.return_value.load_file.call_args_list[0].kwargs
         assert first_kw["container_name"] == CONTAINER
-        assert first_kw["blob_name"].startswith(BLOB_PREFIX.replace("\\", "/"))
+        assert first_kw["blob_name"] == f"{BLOB_PREFIX}/data/a.txt"
         assert first_kw["overwrite"] is True
 
     @mock.patch("airflow.providers.microsoft.azure.transfers.gcs_to_wasb.WasbHook")
@@ -128,7 +117,7 @@ def test_execute_skips_gcs_directory_placeholder_keys(self, mock_gcs_hook, mock_
         )
         result = op.execute(context=None)
 
-        assert _norm_paths(result) == ["src/airflow.png"]
+        assert result == ["src/airflow.png"]
         mock_wasb_hook.return_value.load_file.assert_called_once()
         assert mock_wasb_hook.return_value.load_file.call_args.kwargs["blob_name"] == "src/airflow.png"
         assert mock_wasb_hook.return_value.load_file.call_args.kwargs["overwrite"] is True
@@ -154,7 +143,7 @@ def test_execute_skip_existing_when_replace_false(self, mock_gcs_hook, mock_wasb
         )
         result = op.execute(context=None)
 
-        assert _norm_paths(result) == _expected_blob_paths(BLOB_PREFIX, "data/b.txt")
+        assert result == [f"{BLOB_PREFIX}/data/b.txt"]
         mock_wasb_hook.return_value.load_file.assert_called_once()
         assert mock_wasb_hook.return_value.load_file.call_args.kwargs["overwrite"] is False
 
@@ -177,9 +166,9 @@ def test_flatten_structure(self, mock_gcs_hook, mock_wasb_hook):
         )
         result = op.execute(context=None)
 
-        assert _norm_paths(result) == _expected_blob_paths(BLOB_PREFIX, "a.txt")
+        assert result == [f"{BLOB_PREFIX}/a.txt"]
         kw = mock_wasb_hook.return_value.load_file.call_args.kwargs
-        assert str(kw["blob_name"]).replace("\\", "/") == _expected_blob_paths(BLOB_PREFIX, "a.txt")[0]
+        assert kw["blob_name"] == f"{BLOB_PREFIX}/a.txt"
         assert kw["overwrite"] is True
 
     @mock.patch("airflow.providers.microsoft.azure.transfers.gcs_to_wasb.WasbHook")
@@ -201,7 +190,7 @@ def test_execute_dedups_collisions_when_replace_true(self, mock_gcs_hook, mock_w
         )
         result = op.execute(context=None)
 
-        assert _norm_paths(result) == _expected_blob_paths(BLOB_PREFIX, "file.txt")
+        assert result == [f"{BLOB_PREFIX}/file.txt"]
         mock_wasb_hook.return_value.load_file.assert_called_once()
 
     @mock.patch("airflow.providers.microsoft.azure.transfers.gcs_to_wasb.WasbHook")
@@ -226,7 +215,7 @@ def test_execute_is_idempotent_on_retry(self, mock_gcs_hook, mock_wasb_hook):
         first = op.execute(context=None)
         second = op.execute(context=None)
 
-        assert _norm_paths(first) == _norm_paths(second)
+        assert first == second
         assert op.blob_prefix == BLOB_PREFIX
 
     @mock.patch("airflow.providers.microsoft.azure.transfers.gcs_to_wasb.WasbHook")
