[DNS] Document shadowed records and shadow metadata#31731
[DNS] Document shadowed records and shadow metadata#31731matildeopbravo wants to merge 3 commits into
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
4975690 to
ca9e9b5
Compare
There was a problem hiding this comment.
Verdict: 5 style issues need fixing before merge. No build breakers.
Issues:
- HIGH (line 28):
ns1.externalprovider.comis not a reserved example domain and could resolve to a live origin. Replace withns1.example.org. - MEDIUM (line 4):
descriptionexceeds the 160-character limit. Shorten to stay within the style guide range. - MEDIUM (line 9): H1 heading in body content duplicates the frontmatter
title. Remove it to match other pages in this directory. - LOW (line 20): Directional language (
below) andSeeshould beRefer to. - LOW (lines 171, 180): Placeholders
<ns-record-id>should be<NS_RECORD_ID>(uppercase, underscores) per non-API placeholder conventions.
Note: Consider adding products:\n - dns to frontmatter for consistency with sibling reference pages. The changelog checkbox is unchecked — if include_shadow_metadata is new API behavior, add a changelog entry.
| --- | ||
| title: Shadowed records | ||
| pcx_content_type: concept | ||
| description: Shadowed records are DNS records that exist in your zone but are never served because a subdomain delegation takes precedence. Learn how Cloudflare detects and annotates them. |
There was a problem hiding this comment.
Shorten to meet the 160-character limit:
| description: Shadowed records are DNS records that exist in your zone but are never served because a subdomain delegation takes precedence. Learn how Cloudflare detects and annotates them. | |
| description: DNS records that exist in your zone but are never served because a subdomain delegation takes precedence. Learn how Cloudflare detects and annotates them. |
| order: 5 | ||
| --- | ||
|
|
||
| # Shadowed records |
There was a problem hiding this comment.
Remove this H1 heading. The title frontmatter already renders as the page H1. Sibling reference pages in this directory do not include an H1 in body content.
| Shadowed records are invisible to DNS resolvers. Consider this example: | ||
|
|
||
| ```txt | ||
| sub.example.com NS ns1.externalprovider.com. |
There was a problem hiding this comment.
Use a reserved example domain to avoid resolving to a live origin:
| sub.example.com NS ns1.externalprovider.com. | |
| sub.example.com NS ns1.example.org. |
| This metadata is exposed in two places: as fields on API responses (covering whether a record is shadowed, whether it serves a special role as glue, and how many records a delegation hides) and as warnings in the Cloudflare dashboard on record creation and in the DNS record list. | ||
|
|
||
| :::note | ||
| Shadow metadata is computed on demand at read time and is never stored. It is not returned unless you explicitly request it. See [Request shadow metadata](#request-shadow-metadata) below. |
There was a problem hiding this comment.
Avoid directional language. Use Refer to instead of See:
| Shadow metadata is computed on demand at read time and is never stored. It is not returned unless you explicitly request it. See [Request shadow metadata](#request-shadow-metadata) below. | |
| Shadow metadata is computed on demand at read time and is never stored. It is not returned unless you explicitly request it. Refer to [Request shadow metadata](#request-shadow-metadata). |
| "name": "ns1.sub.example.com", | ||
| "content": "192.0.2.1", | ||
| "meta": { | ||
| "shadowed_by": ["<ns-record-id>"], |
There was a problem hiding this comment.
Use uppercase placeholder format consistent with style guide conventions:
| "shadowed_by": ["<ns-record-id>"], | |
| "shadowed_by": ["<NS_RECORD_ID>"], |
|
I have completed the review of PR #31731. Here's a summary of what I did: Labels applied: Review summary: I posted a review comment with 5 inline suggestions/comments. The PR introduces a well-structured DNS reference page for shadowed records and shadow metadata. The main issues I flagged are:
I also noted that the author should consider adding |
…ords.mdx Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Shorten description under the 160-char limit, add products frontmatter, remove the duplicate H1, use a reserved example domain, fix the remaining placeholder, and replace directional link text.
|
Preview URL: https://bfc023b6.preview.developers.cloudflare.com Files with changes (up to 15) |
Summary
Adds a new DNS reference page documenting shadowed records and the shadow metadata API behavior.
The page explains what shadowed records are, covers glue and dead glue records, and documents the shadow metadata fields (
shadowed_by,is_glue,dead_glue,shadowed_records_count) along with how to request them.Documentation checklist