Skip to content

Tests: Exclude tests based on compilation flags, not API presence #5069

Description

@mgol

Description

We shouldn't treat presence of particular APIs to decide whether to run a test as then if we accidentally remove an API, the tests would still not fail. This has already happened when we removed String.prototype.trim on master without its tests and nothing failed since the tests were being guarded by a check for the existence of this method.

Tests should detect which modules are included in the current compilation by inspecting jQuery.fn.jquery and decide which tests to run based on that.

Link to test case

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions