From 2785b9913b383e0612309666de58d66956b56d75 Mon Sep 17 00:00:00 2001 From: Gokmen Goksel Date: Fri, 18 Nov 2016 14:35:04 +0300 Subject: [PATCH 1/2] ShowSaveDialog: fix button naming --- client/app/lib/util/showSaveDialog.coffee | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/client/app/lib/util/showSaveDialog.coffee b/client/app/lib/util/showSaveDialog.coffee index 40d4ca36bfd..5e530614c28 100644 --- a/client/app/lib/util/showSaveDialog.coffee +++ b/client/app/lib/util/showSaveDialog.coffee @@ -16,10 +16,12 @@ module.exports = (container, callback = kd.noop, options = {}) -> container : container height : 'auto' buttons : - SAVE : + save : + title : 'SAVE' style : 'GenericButton primary' callback : -> callback input, finderController, dialog - CANCEL : + cancel : + title : 'CANCEL' style : 'GenericButton cancel' callback : -> finderController.stopAllWatchers() @@ -38,7 +40,7 @@ module.exports = (container, callback = kd.noop, options = {}) -> label : label defaultValue : options.inputDefaultValue or '' keydown : (event) -> - dialog.buttons.Save.click() if event.which is 13 + dialog.buttons.save.click() if event.which is 13 dialog.on 'KDObjectWillBeDestroyed', -> container.ace?.focus() From aa9fe374f3b46b9b8ad1cbf20d0ce056570a22cf Mon Sep 17 00:00:00 2001 From: Gokmen Goksel Date: Fri, 18 Nov 2016 16:00:53 +0300 Subject: [PATCH 2/2] Popover: wrap with custom div for styling since it's removed from Portal ref: https://github.com/tajo/react-portal/commit/e02033099af03a53262bf43110b7adf84f75d273 --- client/app/lib/components/common/popover.coffee | 6 ++++-- .../app/lib/components/profile/profilefetchermixin.coffee | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/client/app/lib/components/common/popover.coffee b/client/app/lib/components/common/popover.coffee index 1aaa355e3e6..c23facdca65 100644 --- a/client/app/lib/components/common/popover.coffee +++ b/client/app/lib/components/common/popover.coffee @@ -33,6 +33,8 @@ module.exports = class Popover extends React.Component render: -> - -
{@props.children}
+ +
+
{@props.children}
+
diff --git a/client/app/lib/components/profile/profilefetchermixin.coffee b/client/app/lib/components/profile/profilefetchermixin.coffee index 38ce627d232..31e4be0ac56 100644 --- a/client/app/lib/components/profile/profilefetchermixin.coffee +++ b/client/app/lib/components/profile/profilefetchermixin.coffee @@ -2,7 +2,7 @@ React = require 'app/react' helper = require './helper' fetchAccount = require 'app/util/fetchAccount' -module.exports = +module.exports = ProfileFetcherMixin = getInitialState: ->