forked from cloudflare/mcp
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathapi-token-mode.test.ts
More file actions
345 lines (305 loc) · 11.1 KB
/
Copy pathapi-token-mode.test.ts
File metadata and controls
345 lines (305 loc) · 11.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
import { env, exports } from 'cloudflare:workers'
import { ExternalTokenError } from '@cloudflare/workers-oauth-provider'
import { http, HttpResponse } from 'msw'
import { afterEach, describe, expect, it, vi } from 'vitest'
import {
buildAuthProps,
cloudflareTokenOwner,
resolveExternalToken
} from '../../src/auth/api-token-mode'
import { AUTH_PROPS_VERSION } from '../../src/auth/types'
import { API_BASE, cfAccountsSuccess, cfError, cfSuccess } from '../helpers/cloudflare-api'
import { clearKv } from '../helpers/kv'
import { MCP_URL, modernMcpRequest } from '../helpers/mcp'
import { server } from '../setup/msw'
vi.mock('../../src/utils/fetch-retry', async (importOriginal) => {
const original = await importOriginal<typeof import('../../src/utils/fetch-retry')>()
return {
...original,
fetchWithRetry: (input: RequestInfo, init?: RequestInit) =>
original.fetchWithRetry(input, init, { maxRetries: 0 })
}
})
const USER = { id: 'user-1', email: 'user@example.com' }
const ACCOUNT = { id: 'account-1', name: 'Account One' }
function resolverInput(token: string) {
return {
token,
request: new Request(MCP_URL),
env
}
}
async function sha256Hex(value: string): Promise<string> {
const digest = await crypto.subtle.digest('SHA-256', new TextEncoder().encode(value))
return [...new Uint8Array(digest)].map((byte) => byte.toString(16).padStart(2, '0')).join('')
}
function mockIdentity(opts: { user?: () => Response; accounts?: () => Response }): {
userCalls: () => number
accountCalls: () => number
} {
let userCalls = 0
let accountCalls = 0
if (opts.user) {
server.use(
http.get(`${API_BASE}/user`, () => {
userCalls++
return opts.user!()
})
)
}
if (opts.accounts) {
server.use(
http.get(`${API_BASE}/accounts`, () => {
accountCalls++
return opts.accounts!()
})
)
}
return { userCalls: () => userCalls, accountCalls: () => accountCalls }
}
async function expectExternalTokenError(
promise: Promise<unknown>,
code: string,
statusCode: number
): Promise<ExternalTokenError> {
try {
await promise
throw new Error('Expected ExternalTokenError')
} catch (error) {
expect(error).toBeInstanceOf(ExternalTokenError)
expect(error).toMatchObject({ code, statusCode })
return error as ExternalTokenError
}
}
afterEach(() => clearKv(env.OAUTH_KV))
describe('Cloudflare token ownership', () => {
it.each([
['cfat_account-token', 'account'],
['cfut_user-token', 'user'],
['cfoat_wrangler-token', 'user'],
['legacy-unprefixed-token', 'unknown']
] as const)('classifies %s as %s', (token, owner) => {
expect(cloudflareTokenOwner(token)).toBe(owner)
})
})
describe('buildAuthProps', () => {
it('builds versioned user props', () => {
expect(
buildAuthProps('token', {
type: 'user',
user: USER,
accounts: [ACCOUNT],
accountCount: 1
})
).toEqual({
type: 'user_token',
accessToken: 'token',
user: USER,
accounts: [ACCOUNT],
accountCount: 1,
version: AUTH_PROPS_VERSION
})
})
it('builds account props from an account identity', () => {
expect(buildAuthProps('token', { type: 'account', account: ACCOUNT })).toEqual({
type: 'account_token',
accessToken: 'token',
account: ACCOUNT
})
})
})
describe('resolveExternalToken', () => {
it('uses only /accounts for prefixed account tokens', async () => {
const calls = mockIdentity({
user: () => HttpResponse.json(cfSuccess(USER)),
accounts: () => HttpResponse.json(cfAccountsSuccess([ACCOUNT]))
})
await expect(resolveExternalToken(resolverInput('cfat_account-token'))).resolves.toEqual({
props: {
type: 'account_token',
accessToken: 'cfat_account-token',
account: ACCOUNT
},
audience: env.MCP_RESOURCE
})
expect(calls.userCalls()).toBe(0)
expect(calls.accountCalls()).toBe(1)
})
it.each(['cfut_user-token', 'cfoat_wrangler-token'])(
'uses /user and /accounts for prefixed user credential %s',
async (token) => {
const calls = mockIdentity({
user: () => HttpResponse.json(cfSuccess(USER)),
accounts: () => HttpResponse.json(cfAccountsSuccess([ACCOUNT]))
})
await expect(resolveExternalToken(resolverInput(token))).resolves.toMatchObject({
props: { type: 'user_token', accessToken: token, user: USER, accounts: [ACCOUNT] },
audience: env.MCP_RESOURCE
})
expect(calls.userCalls()).toBe(1)
expect(calls.accountCalls()).toBe(1)
}
)
it('retains response-based account inference for legacy credentials', async () => {
const calls = mockIdentity({
user: () => HttpResponse.json(cfError([], null), { status: 403 }),
accounts: () => HttpResponse.json(cfAccountsSuccess([ACCOUNT]))
})
await expect(
resolveExternalToken(resolverInput('legacy-account-token'))
).resolves.toMatchObject({
props: { type: 'account_token', account: ACCOUNT }
})
expect(calls.userCalls()).toBe(1)
expect(calls.accountCalls()).toBe(1)
})
it('does not infer account ownership for a known user token', async () => {
mockIdentity({
user: () => HttpResponse.json(cfError([], null), { status: 403 }),
accounts: () => HttpResponse.json(cfAccountsSuccess([ACCOUNT]))
})
const error = await expectExternalTokenError(
resolveExternalToken(resolverInput('cfut_user-token-no-user-scope')),
'insufficient_scope',
403
)
expect(error.requiredScopes).toEqual(['user:read', 'account:read'])
})
it('uses account-only scope guidance for account token failures', async () => {
const calls = mockIdentity({
user: () => HttpResponse.json(cfSuccess(USER)),
accounts: () => HttpResponse.json(cfError([], null), { status: 403 })
})
const error = await expectExternalTokenError(
resolveExternalToken(resolverInput('cfat_account-token-no-read-scope')),
'insufficient_scope',
403
)
expect(error.requiredScopes).toEqual(['account:read'])
expect(calls.userCalls()).toBe(0)
expect(calls.accountCalls()).toBe(1)
})
it('caches a verified identity by token hash', async () => {
const calls = mockIdentity({
user: () => HttpResponse.json(cfSuccess(USER)),
accounts: () => HttpResponse.json(cfAccountsSuccess([ACCOUNT]))
})
const input = resolverInput('cfut_cached-user-token')
await resolveExternalToken(input)
await resolveExternalToken(input)
expect(calls.userCalls()).toBe(1)
expect(calls.accountCalls()).toBe(1)
})
it('ignores malformed cached identity data and revalidates upstream', async () => {
const token = 'cfut_invalid-cache-token'
await env.OAUTH_KV.put(
`api-token-identity:v4:${await sha256Hex(token)}`,
JSON.stringify({ user: 'not-an-object', accounts: [] })
)
const calls = mockIdentity({
user: () => HttpResponse.json(cfSuccess(USER)),
accounts: () => HttpResponse.json(cfAccountsSuccess([ACCOUNT]))
})
await expect(resolveExternalToken(resolverInput(token))).resolves.toMatchObject({
props: { type: 'user_token', user: USER, accounts: [ACCOUNT] }
})
expect(calls.userCalls()).toBe(1)
expect(calls.accountCalls()).toBe(1)
})
it('maps malformed credentials to invalid_token', async () => {
mockIdentity({
user: () => HttpResponse.json(cfError([], null), { status: 400 }),
accounts: () => HttpResponse.json(cfError([], null), { status: 400 })
})
const error = await expectExternalTokenError(
resolveExternalToken(resolverInput('malformed-token')),
'invalid_token',
401
)
expect(error.description).toContain('appears malformed')
})
it('preserves rate-limit backoff', async () => {
mockIdentity({
user: () =>
HttpResponse.json(cfError([], null), {
status: 429,
headers: { 'Retry-After': '17' }
}),
accounts: () => HttpResponse.json(cfError([], null), { status: 429 })
})
const error = await expectExternalTokenError(
resolveExternalToken(resolverInput('cfoat_rate-limited-token')),
'temporarily_unavailable',
429
)
expect(error.headers).toEqual({ 'Retry-After': '17' })
})
it('maps upstream failures to server_error', async () => {
mockIdentity({
user: () => HttpResponse.json(cfError([], null), { status: 502 }),
accounts: () => HttpResponse.json(cfError([], null), { status: 401 })
})
await expectExternalTokenError(
resolveExternalToken(resolverInput('legacy-upstream-failure')),
'server_error',
502
)
})
})
describe('external token resource responses', () => {
it('lets the provider construct the RFC 6750/9728 invalid-token response', async () => {
mockIdentity({
user: () => HttpResponse.json(cfError([], null), { status: 400 }),
accounts: () => HttpResponse.json(cfError([], null), { status: 400 })
})
const response = await exports.default.fetch(
modernMcpRequest('malformed-provider-token', 'server/discover')
)
expect(response.status).toBe(401)
expect(response.headers.get('cache-control')).toBe('no-store')
expect(response.headers.get('www-authenticate')).toContain('error="invalid_token"')
expect(response.headers.get('www-authenticate')).toContain(
`resource_metadata="${new URL(MCP_URL).origin}/.well-known/oauth-protected-resource/mcp"`
)
await expect(response.json()).resolves.toEqual({
error: 'invalid_token',
error_description: 'Access token appears malformed; reauthenticate and try again'
})
})
it('lets the provider construct an insufficient-scope challenge', async () => {
mockIdentity({
user: () => HttpResponse.json(cfError([], null), { status: 403 }),
accounts: () => HttpResponse.json(cfAccountsSuccess([ACCOUNT]))
})
const response = await exports.default.fetch(
modernMcpRequest('cfut_provider-insufficient-scope', 'server/discover')
)
expect(response.status).toBe(403)
expect(response.headers.get('www-authenticate')).toContain('error="insufficient_scope"')
expect(response.headers.get('www-authenticate')).toContain('scope="user:read account:read"')
await expect(response.json()).resolves.toEqual({
error: 'insufficient_scope',
error_description: 'Token lacks required user:read or account:read scope'
})
})
it('lets the provider preserve a retryable rate-limit response', async () => {
mockIdentity({
user: () =>
HttpResponse.json(cfError([], null), {
status: 429,
headers: { 'Retry-After': '23' }
}),
accounts: () => HttpResponse.json(cfError([], null), { status: 429 })
})
const response = await exports.default.fetch(
modernMcpRequest('cfoat_provider-rate-limit', 'server/discover')
)
expect(response.status).toBe(429)
expect(response.headers.get('retry-after')).toBe('23')
expect(response.headers.get('cache-control')).toBe('no-store')
await expect(response.json()).resolves.toEqual({
error: 'temporarily_unavailable',
error_description: 'Rate limited, try again later'
})
})
})