From 9ee7a9d801bfca0db90be22e8d890f22d23464b8 Mon Sep 17 00:00:00 2001 From: Remy Suen Date: Sat, 4 Feb 2017 17:17:55 +0900 Subject: [PATCH] Make `RevertOptions` parameter optional in `Revert.revert` libgit2's git_revert function does not require the revert options to be specified so the same should apply to the NodeGit API. --- generate/input/descriptor.json | 5 +++++ test/tests/revert.js | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json index bc628cb3d..2135a355d 100644 --- a/generate/input/descriptor.json +++ b/generate/input/descriptor.json @@ -2044,6 +2044,11 @@ "functions": { "git_revert": { "isAsync": true, + "args": { + "given_opts": { + "isOptional": true + } + }, "return": { "isErrorCode": true } diff --git a/test/tests/revert.js b/test/tests/revert.js index b3f151831..a16d8c126 100644 --- a/test/tests/revert.js +++ b/test/tests/revert.js @@ -60,4 +60,11 @@ describe("Revert", function() { assert.ok(_.endsWith(fileName, entries[0].path)); }); }); + + it("RevertOptions is optional", function() { + return Revert.revert(test.repository, test.firstCommit, null) + .catch(function(error) { + throw error; + }); + }); });