chore: change the installation flow and document in readme - #145
Merged
Conversation
alex-ilgayev
force-pushed
the
chore/readme-update
branch
2 times, most recently
from
November 9, 2023 20:25
07dcc28 to
8447328
Compare
alex-ilgayev
requested review from
elad-pticha and
oreenlivnicode
and removed request for
elad-pticha and
oreenlivnicode
November 9, 2023 20:28
alex-ilgayev
force-pushed
the
chore/readme-update
branch
3 times, most recently
from
November 9, 2023 20:36
55ac9fe to
41c6036
Compare
alex-ilgayev
marked this pull request as draft
November 9, 2023 21:15
alex-ilgayev
force-pushed
the
chore/readme-update
branch
9 times, most recently
from
November 9, 2023 22:11
37255e7 to
217ad26
Compare
alex-ilgayev
marked this pull request as ready for review
November 9, 2023 22:15
oreenlivnicode
approved these changes
Nov 12, 2023
elad-pticha
approved these changes
Nov 12, 2023
alex-ilgayev
force-pushed
the
chore/readme-update
branch
from
November 12, 2023 16:49
217ad26 to
f5800c8
Compare
Contributor
|
@alex-ilgayev We can also add |
alex-ilgayev
force-pushed
the
chore/readme-update
branch
2 times, most recently
from
November 13, 2023 11:43
5c03827 to
231e117
Compare
alex-ilgayev
force-pushed
the
chore/readme-update
branch
from
November 13, 2023 11:47
231e117 to
cbb8fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced the following changes:
docker runin addition to thedocker compose. The development flow, that is part of theCONTRIBUTING.mdfile now, is a bit more complex, and involves cloning, and testing.pip3 install .. Running the program withpython3 main.py ...is much simpler. Alsopip3 install .requiressudopermissions.make clean-setupto remove the redis and neo4j.pip3 install ., themake setupdoesn't needssudo.docker-compose.ymlpersistent.