Making folder paths to relative#25
Closed
juvander wants to merge 11 commits into
Closed
Conversation
additions to gitignore
Member
Author
|
Any comment for this, go/no-go? |
Member
|
It is a bit hard to review at a glance with all those commits and I currently don't have a proper test bed for this module. Will get to it when possible. Thanks. |
Member
|
Oh, I think I know what happend, you submitted this pull request from your master branch instead of a branch specific for this issue because I see other pull requests from you with the same commits. |
Member
Author
|
That is very well possible, but those other ones should be now separated. Will see your comments on those later today. |
Member
|
Replaced by #41 as a cherry pick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #24
I believe these will do the same as for VB version. There was some nuget errors so could not get this project to compile.