Skip to content

#58 Keep backward compatibility for upgraded modules that contains some customized storage locations#60

Merged
valadas merged 2 commits into
DNNCommunity:developfrom
stetard:Accept-Old-Customized-Storage-Locations
Dec 8, 2023
Merged

#58 Keep backward compatibility for upgraded modules that contains some customized storage locations#60
valadas merged 2 commits into
DNNCommunity:developfrom
stetard:Accept-Old-Customized-Storage-Locations

Conversation

@stetard

@stetard stetard commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

Description of PR...

Changed the code to take into account some potentials customized storage locations for upgraded modules.

Changes made

  • Settings Form: add the ability to display customized locations instead of the defaults
  • Helpers: introduce Default values for the 3 storage locations and compare them to the current module settings to use the corrects values.

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Close #58

@maduranga001

maduranga001 commented Nov 24, 2023

Copy link
Copy Markdown

Please, can somebody share the DLL file which includes all the last changes? Thank you so much.

valadas
valadas approved these changes Dec 8, 2023
View reviewed changes

@valadas valadas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing sticks out to me, thanks.

@valadas valadas merged commit cfa809c into DNNCommunity:develop Dec 8, 2023
@valadas valadas added the bug Something isn't working label Dec 8, 2023
@valadas valadas added this to the 4.1.2 milestone Dec 8, 2023
@stetard

stetard commented Dec 8, 2023

Copy link
Copy Markdown
Contributor Author

@maduranga001 you can download my dll at https://www.aricie.com/DotNetNuke.Modules.Repository.dll_patched.zip if needed.

@maduranga001

maduranga001 commented Dec 8, 2023

Copy link
Copy Markdown

@maduranga001 you can download my dll at https://www.aricie.com/DotNetNuke.Modules.Repository.dll_patched.zip if needed.

404 - File or directory not found.
Please, can you check and give me the correct link?
Thank you!

@stetard

stetard commented Dec 8, 2023

Copy link
Copy Markdown
Contributor Author

Sorry, it's a wrong url.
The correct url is https://download.aricie.com/DotNetNuke.Modules.Repository.dll_patched.zip

@maduranga001

maduranga001 commented Dec 8, 2023 via email

Copy link
Copy Markdown

@valadas

valadas commented Dec 8, 2023

Copy link
Copy Markdown
Member

I have just released a new version here if you want the full package https://github.com/DNNCommunity/DNN.Repository/releases/tag/v4.1.2

@maduranga001

maduranga001 commented Dec 8, 2023 via email

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valadas valadas valadas approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

Breaking change regarding the files storage location

3 participants

@stetard @maduranga001 @valadas