Fixed an html encoding issue#97
Merged
Merged
Conversation
Member
Author
|
Oops, I merged into the wrong branch, will do an extra PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
@stetard FYI
This is a classic issue of double encoding.
There are generally 2 parts to preventing XSS.
HtmlUtils.StripTagswhich will remove any html/script tags and only return a plain string without any tags. For html content it is a bit more complex and I will explain later.Now for html content is is slightly different:
We don't want to remove all tags but still sanitize for no scripts. There is a method for that in
HtmlUtils.SanitizeHtmlIfNeeded.I will merge this and do a new beta if you have existing data you can test this out with.