Move protobuf requirement to pyproject.toml - #3235
Merged
Merged
Conversation
MMathisLab
approved these changes
Mar 19, 2026
While the protobuf pin was temporarily added to CI only, the requirement should be added to the tf optional dependency group in pyproject.toml
C-Achard
force-pushed
the
cy/move-protobuf-to-reqs
branch
from
March 30, 2026 18:21
1df5ab0 to
d881d8a
Compare
Collaborator
Author
|
Rebased as per #3263 |
Mark changes under .github/workflows/ as a full-suite trigger by adding a trigger entry to FULL_SUITE_TRIGGERS, and comment out the ci_workflows CategoryRule to stop running minimal tests.
Rename test to reflect that CI workflows should trigger the full pytest suite and update assertions accordingly. Replaced assert_lanes(..., fast=True) with assert_lanes(..., full=True) and removed checks that CI workflows map to the minimal pytest path and related provenance assertions.
deruyter92
approved these changes
Apr 8, 2026
Collaborator
Author
|
Thanks @deruyter92, merging now ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the protobuf pin was temporarily added to CI only, the requirement should be added to the tf optional dependency group in pyproject.toml.
Strongly recommended before merging :