Skip to content

manually update nightly version to 2026-06-11.#283

Merged
delta1 merged 1 commit into
ElementsProject:masterfrom
apoelstra:2026-06/nightly
Jun 30, 2026
Merged

manually update nightly version to 2026-06-11.#283
delta1 merged 1 commit into
ElementsProject:masterfrom
apoelstra:2026-06/nightly

Conversation

@apoelstra

Copy link
Copy Markdown
Member

Clippy removed the from_iter_instead_of_collect lint due to being "problematic". I don't know that we ever used this, but we had explicitly enabled it.

Clippy also added a new needless_return_with_question_mark lint which fires numerous times throughout the crate.

Supercedes #274.

@delta1

delta1 commented Jun 17, 2026

Copy link
Copy Markdown
Member

Just missing one callsite

diff --git a/src/pset/mod.rs b/src/pset/mod.rs
index 05ac907..5c03ca6 100644
--- a/src/pset/mod.rs
+++ b/src/pset/mod.rs
@@ -747,7 +747,7 @@ impl Decodable for PartiallySignedTransaction {

             // Maximum pset input size supported
             if inputs_len > 10_000 {
-                return Err(Error::TooLargePset);
+                return Err(Error::TooLargePset.into());
             }

             let mut inputs: Vec<Input> = Vec::with_capacity(inputs_len);

Clippy removed the `from_iter_instead_of_collect` lint due to being
"problematic". I don't know that we ever used this, but we had explicitly
enabled it.

Clippy also added a new `needless_return_with_question_mark` lint which
fires numerous times throughout the crate.

Supercedes ElementsProject#274.
@apoelstra

Copy link
Copy Markdown
Member Author

On c5bac55 successfully ran local tests

@delta1 delta1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c5bac55; tested locally

@delta1 delta1 merged commit 12441ee into ElementsProject:master Jun 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants