core(artifacts): encapsulate node details in an object (#11474) (reland) - #11695
Merged
Conversation
paulirish
marked this pull request as ready for review
December 1, 2020 17:55
paulirish
requested review from
a team and
patrickhulce
and removed request for
a team
December 1, 2020 17:56
patrickhulce
suggested changes
Dec 1, 2020
Collaborator
There was a problem hiding this comment.
I think we have one too many revert in here or something @paulirish ? 0/0 changes :)
paulirish
force-pushed
the
relandencap
branch
from
December 7, 2020 23:26
eb37813 to
8e28eaf
Compare
artifacts.json and sampl3v2json
…ts ScriptElements LinkElements ImageElements AnchorElements TapTargets TraceElements'
patrickhulce
approved these changes
Dec 8, 2020
Contributor
|
Nice! Thanks for cleaning this up, it was a hefty PR! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reland of #11474
See #11694 for revert details.
It's already reviewed and LGTM'd.Update: merging master in introduced quite a few conflicts (brendan's nodevalue type change, @adrianaixba's ImageElements resourcesize change, etc), so in resolving the conflicts, I did make enough changes to warrant a quick once-over.
Notably, I changed artifacts.json quite a bit from where it was in #11474. I optimized for the smallest amount of changes to sample_v2.json, and am happy with the results (just ~4 lines changed to that file).