core(trace): enable JS samples for advanced workflows - #15542
Merged
Conversation
Contributor
Author
|
Seems like Edit: ope should have just looked at #12835 |
This reverts commit 55eac1e.
Collaborator
|
Is this change still producing issues? The current CI failure looks like a previously-accepted-to-be-flaky test. |
connorjclark
approved these changes
Dec 19, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature request from internal chat. Lighthouse doesn't currently use JS samples for anything meaningful, but they are still useful for advanced workflows looking at the trace (e.g. "View Trace" button in DT). Considering we eventually want to use these JS samples for things like 3P attribution, it shouldn't hurt to enable samples for these use cases.
Closes #15599