This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Clean up percy. - #2498
Merged
Merged
Conversation
|
Deploy preview for web-dev-staging ready! Built with commit 915fb24 |
This was referenced Apr 2, 2020
MichaelSolati
approved these changes
Apr 3, 2020
MichaelSolati
left a comment
Contributor
There was a problem hiding this comment.
Where is the environment set? Otherwise lgtm
Contributor
Author
|
@MichaelSolati it's set in package.json when you do |
Contributor
|
Kk, I don't think I saw it in the changes, but kk |
Contributor
Author
|
ah yeah it was done in a previous pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
I think at some point we should probably rename the
site.envvariable since it's specific to eleventy at this point but I didn't want to do that in this PR for fear of breaking something unseen.