This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Update Native File System article - #2543

Merged

kaycebasques merged 10 commits into

Apr 15, 2020

petele commented Apr 9, 2020 •

edited

Loading

Contributor

Changes proposed in this pull request:

Updates WritableStream
Adds serializability of FileHandles

Still TODO:

Add comment about getFile only valid while the file hasn't changed
Update images
Add some sample code for saving file handle to indexed db
Verify permissions section has info about permission being for the domain, not the tab.


          first draft of changes to nfs article

a74abed

petele added DO NOT MERGE capabilities content update labels

petele requested a review from kaycebasques as a code owner

April 9, 2020 20:22

petele self-assigned this

googlebot added the cla: yes label

petele mentioned this pull request

content: Update Native File System article #2542

Closed

netlify Bot commented Apr 9, 2020 •

edited

Loading

Deploy preview for web-dev-staging ready!

Built with commit 04b6643

https://deploy-preview-2543--web-dev-staging.netlify.com

tomayac commented Apr 9, 2020

Member

Fixes #2542

tomayac reviewed

View reviewed changes

src/site/content/en/blog/native-file-system/index.md Outdated

tomayac approved these changes

View reviewed changes

tomayac left a comment

Member

Non-owner LGTM


          Update src/site/content/en/blog/native-file-system/index.md

6bd0b07

Co-Authored-By: Thomas Steiner <steiner.thomas@gmail.com>

googlebot commented Apr 9, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot added cla: no and removed cla: yes labels

petele added cla: yes and removed cla: no labels

googlebot commented Apr 9, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

mkruisselbrink reviewed

View reviewed changes

mkruisselbrink left a comment

Mostly this looks great! Some ideas for possible improvements/future improvements.

Also there is this sentence somewhere in there: "In the next few versions of Chrome, installed Progressive Web Apps will also be able to save the handle to IndexedDB and persist access to the file across page reloads." which is no longer applicable. That feature actually now is available for all websites (not just PWAs).

src/site/content/en/blog/native-file-system/index.md

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md


          address feedback from mkruisselbrink

74a90ba

googlebot commented Apr 10, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot added cla: no and removed cla: yes labels

jpmedley suggested changes

View reviewed changes

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated


          address additional feedback

11e0f3c

petele added cla: yes and removed cla: no labels

googlebot commented Apr 10, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.


          fugu-status

16ade3c

googlebot commented Apr 13, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot added cla: no and removed cla: yes labels

petele added cla: yes and removed cla: no labels

googlebot commented Apr 13, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

jpmedley changed the title ~~Update Native File System article for Cr82~~ Update Native File System article

jpmedley approved these changes

View reviewed changes

petele assigned kaycebasques and unassigned petele

kaycebasques approved these changes

View reviewed changes

kaycebasques left a comment

Contributor

A couple typos. I'll commit them myself and then merge.

src/site/content/en/blog/native-file-system/index.md Outdated

src/site/content/en/blog/native-file-system/index.md Outdated


          Update src/site/content/en/blog/native-file-system/index.md

3ca83c9

googlebot commented Apr 15, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot added cla: no and removed cla: yes labels


          Update src/site/content/en/blog/native-file-system/index.md

04b6643

kaycebasques added cla: yes and removed cla: no labels

googlebot commented Apr 15, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

kaycebasques merged commit 69ab312 into master

kaycebasques deleted the nfs-v2 branch

April 15, 2020 00:17

agektmr pushed a commit that referenced this pull request


          Update Native File System article (#2543)

22dc137

Fixes #2542

kaled336 mentioned this pull request

[Snyk] Fix for 5 vulnerabilities kaled336/web.dev#27

Open

MrBrain295 mentioned this pull request

[Snyk] Fix for 5 vulnerabilities MrBrain295/web.dev#44

Open

gr00nd mentioned this pull request

[Snyk] Fix for 5 vulnerabilities gr00nd/web.dev#24

Open

kaled336 mentioned this pull request

[Snyk] Fix for 2 vulnerabilities kaled336/web.dev#29

Open

gr00nd mentioned this pull request

[Snyk] Fix for 2 vulnerabilities gr00nd/web.dev#27

Open

MrBrain295 mentioned this pull request

[Snyk] Fix for 2 vulnerabilities MrBrain295/web.dev#46

Open

MrBrain295 mentioned this pull request

[Snyk] Security upgrade gulp from 4.0.2 to 5.0.0 MrBrain295/web.dev#47

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

Labels

cla: yes content update