Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

covid banner - #2781

Merged
samthor merged 2 commits into
masterfrom
covid-banner
May 12, 2020
Merged

covid banner#2781
samthor merged 2 commits into
masterfrom
covid-banner

Conversation

@samthor

@samthor samthor commented May 4, 2020

Copy link
Copy Markdown
Contributor

Resolves #2709.

I've taken the simplest approach and reused the CDS banner CSS. But honestly this just seems like it's a featured post card. Is there something I'm missing?

also, the designs have a cute stylized graphic, but that doesn't match the hero image we've used for the blog post. I've used the hero but I'm happy to change it.

Screen Shot 2020-05-04 at 12 57 32

@samthor
samthor requested a review from robdodson May 4, 2020 03:01
@googlebot googlebot added the cla: yes Contributor has signed the CLA label May 4, 2020
@netlify

netlify Bot commented May 4, 2020

Copy link
Copy Markdown

Deploy preview for web-dev-staging ready!

Built with commit 78c09c7

https://deploy-preview-2781--web-dev-staging.netlify.app

@robdodson

Copy link
Copy Markdown
Contributor

But honestly this just seems like it's a featured post card. Is there something I'm missing?

I think there are some small differences. The post card will do a big card hover effect and I think it needs to be inside of a grid container. We could try it and see how it looks? I'm fine with either.

also, the designs have a cute stylized graphic, but that doesn't match the hero image we've used for the blog post. I've used the hero but I'm happy to change it.

Good question. I suspect we should use the graphic they gave us and maybe swap out the graphic on the post itself. I think that's what Harleen wanted.

@robdodson

Copy link
Copy Markdown
Contributor

Looks kinda squashed on mobile.

image

@kaycebasques

Copy link
Copy Markdown
Contributor

Yes we should replace the hero image on the post with the provided graphic per Harleen's request

LMK if you want to do it here or if I should create a separate PR

@robdodson

Copy link
Copy Markdown
Contributor

I think we can do it here. I think Sam was going to tweak the CSS a bit first.

@samthor
samthor requested a review from kaycebasques as a code owner May 12, 2020 02:00
@samthor

samthor commented May 12, 2020

Copy link
Copy Markdown
Contributor Author

I've updated the banner while still making it just a regular inline link (not a card). It looks like this:

Screen Shot 2020-05-12 at 11 59 41

Screen Shot 2020-05-12 at 11 59 47

@kaycebasques kaycebasques left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM FWIW

@samthor

samthor commented May 12, 2020

Copy link
Copy Markdown
Contributor Author

My main concerns were around the copy so if Kayce has approved I'll get this in.

@samthor
samthor merged commit 2723e7a into master May 12, 2020
@samthor
samthor deleted the covid-banner branch May 12, 2020 04:05
agektmr pushed a commit that referenced this pull request May 18, 2020
* covid banner

* updates
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Contributor has signed the CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add covid-19 banner to the front page of the site.

4 participants