This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Update with COOP Reporting API - #3797
Merged
Merged
Conversation
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. src/site/content/en/blog/coop-coep/index.md
|
|
Deploy preview for web-dev-staging ready! Built with commit 50ce905 |
camillelamy
reviewed
Aug 27, 2020
agektmr
force-pushed
the
coop-reporting
branch
from
August 31, 2020 06:12
e69cc21 to
37a8fc5
Compare
| type: 'corp' | ||
| "age": 25101, | ||
| "body": { | ||
| "blocked-url": "https://third-party-test.glitch.me/check.svg?", |
There was a problem hiding this comment.
Can we have a note saying that blocked-url will be removed soon, so it's recommended to use blockedURL?
Alternatively it may be good to omit blocked-url.
ParisMeuleman
left a comment
There was a problem hiding this comment.
overall LGTM, with a comment and % Yutaka's comment.
Member
Author
|
@kaycebasques @jpmedley this article is ready to be merged. |
jpmedley
suggested changes
Aug 31, 2020
agektmr
force-pushed
the
coop-reporting
branch
from
September 1, 2020 01:51
6283536 to
50ce905
Compare
Member
Author
|
@jpmedley I think issues are resolved. Can you give it another pass and merge if it looks good? |
jpmedley
approved these changes
Sep 1, 2020
|
Addresses #3689 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blocked-url=>blockedURL