fix(ifctester): allow IFCLOGICAL properties with UNKNOWN value to pass existence check#8161
Open
gernotluidolt wants to merge 1 commit into
Open
Conversation
…s existence check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a false-positive validation error in
IfcTesterwhen checkingIFCLOGICALproperties containing the valueUNKNOWN.Previously, the code hit a silent
passinside theIfcLogicalevaluation block, which prevented the property from being recorded in thepropsdictionary. This caused a false-positiveNOVALUEerror downstream, incorrectly indicating that the property did not exist in the model, even though it was structurally and semantically valid.While requiring an explicit
UNKNOWNvalue in an IDS might be an edge case, the buildingSMART IDS specification supports it. Therefore, the validation engine should handle it correctly rather than throwing a false-positive.Changes
passstatement with a proper dictionary assignment (props[pset_name][self.baseName] = prop) inside theIfcLogicalcondition block insrc/ifctester/ifctester/facet.py.Testing
Verified by using an evaluation pipeline I had set up for my bachelor thesis.
IFCLOGICALproperties set toUNKNOWNnow successfully pass the initial existence filter and can be audited against IDS restrictions as expected.