Place IfcSpatialZone in its spatial parent's collection instead of Unsorted#8174
Open
carlopav wants to merge 1 commit into
Open
Place IfcSpatialZone in its spatial parent's collection instead of Unsorted#8174carlopav wants to merge 1 commit into
carlopav wants to merge 1 commit into
Conversation
…sorted Spatial zones are intentionally excluded from getting their own collection (008fa70) since they are non-hierarchical, but they then fell through to the Unsorted collection because get_container() only follows IfcRelContainedInSpatialStructure while zones added from the spatial decomposition panel are aggregated. As Unsorted is hidden by default, a freshly created spatial zone disappeared from the viewport. Link aggregated spatial zones to the collection of their nearest spatial parent that owns one, mirroring how aggregated elements are placed in their container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spatial zones are intentionally excluded from getting their own collection (008fa70) since they are non-hierarchical, but they then fell through to the Unsorted collection because get_container() only follows IfcRelContainedInSpatialStructure while zones added from the spatial decomposition panel are aggregated. As Unsorted is hidden by default, a freshly created spatial zone disappeared from the viewport.
Link aggregated spatial zones to the collection of their nearest spatial parent that owns one, mirroring how aggregated elements are placed in their container.