Added options to apply or remove labels from source rule app#128
Closed
zkemppel-InRule wants to merge 1 commit into
Closed
Added options to apply or remove labels from source rule app#128zkemppel-InRule wants to merge 1 commit into
zkemppel-InRule wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the PromoteRuleApp command-line tool to support optionally applying or removing labels on the source Rule App as part of the promotion workflow, and refactors source Rule App retrieval to use RuleCatalogConnection APIs.
Changes:
- Added CLI options to apply (
-ApplyLabelToSource) and remove (-RemoveLabelFromSource) labels on the source catalog after promotion. - Switched source Rule App retrieval from
CatalogRuleApplicationReferencetoRuleCatalogConnectionmethods (latest revision vs. by-label). - Updated catalog connection creation to explicitly use
RuleCatalogAuthenticationType.BuiltIn.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| string ruleAppName = null; | ||
| string label = "LIVE"; | ||
| string comment = ""; | ||
| string label = null; |
| } | ||
| else | ||
| { | ||
| var sourceCatCon = new RuleCatalogConnection(new Uri(sourceCatalogUrl), TimeSpan.FromSeconds(60), sourceCatalogUsername, sourceCatalogPassword, RuleCatalogAuthenticationType.BuiltIn); |
Comment on lines
+99
to
+109
| destCatCon.PromoteRuleApplication(sourceRuleAppDef, comment); | ||
|
|
||
| if (!string.IsNullOrEmpty(applyLabelToSource)) | ||
| { | ||
| sourceCatCon.ApplyLabel(sourceRuleAppDef, applyLabelToSource); | ||
| } | ||
|
|
||
| if (!string.IsNullOrEmpty(removeLabelFromSource)) | ||
| { | ||
| sourceCatCon.RemoveLabel(sourceRuleAppDef.Guid, removeLabelFromSource); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.