Fix oracle-check fallback for PGXS modules#1391
Draft
neu-hsc wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8836c75 to
a120174
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REGRESStests throughoracle-checkwhen a module does not defineORA_REGRESS.ISOLATIONtests throughoracle-checkwhen a module does not defineORA_ISOLATION.Root cause
oracle-checkconsidered onlyORA_REGRESSandORA_ISOLATION. Most modules undersrc/oracle_test/modules/define the ordinaryREGRESSorISOLATIONlist, so their Oracle-mode tests were skipped.Validation
make -C src/oracle_test/modules/brin -n oracle-check MAKE=trueschedules onlysummarization-and-inprogress-insertionthrough the Oracle isolation runner.make -C src/oracle_test/modules/commit_ts -n oracle-check MAKE=trueschedules onlycommit_timestampthrough the Oracle regression runner.git diff --checkFixes #1323