Default to looking for tools on PATH, rather than requiring them to be in /usr/bin - #463
Merged
pehrsoderman merged 4 commits intoAug 20, 2026
Conversation
Contributor
Author
|
Codefactor checks are silly (hard coded paths to /tmp in a unit tests are not a security vulnerability. I'll see if I can coax codefactor into being less silly (but iirc, it was a bit annoying to get it to pick up bandit rules in a good way). |
gkreitz
force-pushed
the
103_non_absolute_path_to_language_tools
branch
from
August 20, 2026 09:47
04382b9 to
579363e
Compare
pehrsoderman
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows one to configure a language where the path to the compiler or interpreter is not absolute (e.g.,
gccrather then/usr/bin/gcc). Such paths will be resolved using$PATH. This PR also changes the default config to make use of this, so now it will compile C programs using the firstgccin$PATH, rather than/usr/bin/gcc.Additionally, fixes an old omission. If the runtime for a language (e.g.,
java) is missing, earlier we'd attempt to execute it and give a misleading run-time error. Now, we'll flag that as a compile error, the same way we do if the compiler is missing.Fixes #103