Skip to content

fix: vitest: include .tsx files in test execution#1645

Merged
gkjohnson merged 2 commits into
NASA-AMMOS:masterfrom
MatrixNeoKozak:fix/improvement-1781779008183
Jun 19, 2026
Merged

fix: vitest: include .tsx files in test execution#1645
gkjohnson merged 2 commits into
NASA-AMMOS:masterfrom
MatrixNeoKozak:fix/improvement-1781779008183

Conversation

@MatrixNeoKozak

Copy link
Copy Markdown
Contributor

The vitest configuration incorrectly excluded all .tsx files from the test suite, causing the existing test/r3f/typeCheck.test.tsx to be ignored. This change removes the broad exclusion of .tsx files, ensuring all relevant test files in the project are correctly discovered and executed by the test runner.

Comment thread vitest.config.js Outdated
alias: packageAliases,
},
} );
} ); No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! Once this lint issue is fixed we can get this merged.

@MatrixNeoKozak

Copy link
Copy Markdown
Contributor Author

I have pushed updates to address the feedback and ensure vitest runs smoothly:

  1. Fixed trailing newline: Added the missing trailing newline to vitest.config.js to satisfy the eol-last lint rule.
  2. Wrapped type check in a vitest suite: Since test/r3f/typeCheck.test.tsx was now included in the vitest runs, it was causing a failure because it had no actual vitest tests (only TSX declarations for compile-time check). I wrapped the JSX elements in a standard vitest test block so that it parses and runs successfully in the test suite while keeping the TypeScript compiler check active.

@gkjohnson

Copy link
Copy Markdown
Contributor

Great, thanks!

@gkjohnson gkjohnson merged commit 9fd15b6 into NASA-AMMOS:master Jun 19, 2026
1 check passed
@gkjohnson gkjohnson added this to the v0.5.0 milestone Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants