Upgrade nosto#4
Merged
Merged
Conversation
* Fixed test to include a field because validation in graphql now requires ypes to have one or more fields ( graphql-java/graphql-java#1955 ) * Removed references to arguments when recreation ExecutionStrategyParameters because arguments field was dropped in graphql-java ( https://github.com/graphql-java/graphql-java/pull/2023/files#diff-d31b54bc13a6051c43027e76627c6e99de28f64adfcfcfb275856ec00890cc4fL44 ) * Updated tests to work with immutable structures that graphql-java has moved to ( https://github.com/graphql-java/graphql-java/pull/2086/files#diff-9fed7fa709720e6a47a80119bb991def6fa752f8933d9f5e3dfcede5520c07d6R134 )
…16-support Updating to use latest graphql-java:16.2 library
In 17.0, GraphQLBatched and non-standard Scalars (BigInteger, BigDecimal, Char, Byte, Long, Short) were all removed. Accordingly, removed from here
(deps) Adding graphql-java-extended-scalars 17.0 for non-standard scalars (BigInteger, BigDecimal, Char, Byte, Long, Short). Removing GraphQLBatched as the deprecated `BatchedExecutionStrategy` was finally removed from graphql-java
(deps) Updating to latest graphql-java:17.1 library
Gql java 17.1 - Version 9.0
(deps) update to graphql-java 17.2 (contains several bug fixes)
gary-nosto
reviewed
Oct 6, 2022
|
|
||
| @Override | ||
| public GraphQLSchemaElement copy() { | ||
| return null; |
There was a problem hiding this comment.
I don't think this should return null https://github.com/graphql-java/graphql-java/blob/066c751e01120a9b29531a698769e72fb99bcb67/src/main/java/graphql/schema/GraphQLSchemaElement.java#L59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge latest changes from upstream master
Related PR
https://github.com/Nosto/playcart/pull/25707 (build is failing due to dependency with this PR)