Skip to content

Add prettier configuration file, brazilian portuguese translations and expand translation usage - #135

Open
imLymei wants to merge 6 commits into
PenguLoader:mainfrom
imLymei:main
Open

Add prettier configuration file, brazilian portuguese translations and expand translation usage#135
imLymei wants to merge 6 commits into
PenguLoader:mainfrom
imLymei:main

Conversation

@imLymei

@imLymei imLymei commented Dec 5, 2024

Copy link
Copy Markdown

Description of Changes

This pull request introduces the following improvements and updates:

1. Prettier Configuration File

  • Added a .prettierrc configuration file to ensure consistent code formatting across the project.
  • Standardized formatting rules to improve readability and maintainability of the codebase.

2. Brazilian Portuguese Translations

  • Added key-value pairs for newly implemented features and settings, including:
    • Activation modes
    • Plugin store
    • Client settings

3. Integration of Translations

  • Expanded the use of the existing translation system by incorporating it into additional parts of the application.

Reason for Changes

This pull request addresses the following goals:

  1. Code Consistency and Readability:

    • The addition of a Prettier configuration file ensures consistent code formatting, making the codebase easier to read and collaborate on.

  2. Expand Brazilian Portuguese Coverage:

    • Fully localize the PenguLoader, enhancing accessibility and user experience for Brazilian Portuguese-speaking users.

  3. Improve User Experience:

    • By utilizing translations in more parts of the application, the interface becomes more intuitive and user-friendly for non-English speakers, ensuring a seamless experience.

Any and all feedback is welcome.
The .prettierrc configuration file is merely a suggestion to help standardize the repository.

@nomi-san

nomi-san commented Dec 6, 2024

Copy link
Copy Markdown
Member

Thank you. I will merge it later after publishing the docs about development guide and coding style.

I appreciate your translations and also the .prettierrc, but your changes break the TS style in loader folder that should be opened in editor as a separate workspace 😅.

@imLymei

imLymei commented Dec 6, 2024

Copy link
Copy Markdown
Author

Sorry about that. What should i do to help? Should i wait until the docs are out?

@nomi-san

nomi-san commented Dec 7, 2024

Copy link
Copy Markdown
Member

Ah you can rebase the last commit (8963526) or add a new commit to override it. Note that you should open the loader folder in VSCode, there are settings (in .vscode/) that help you format the code with default TS formatter.

{
  "editor.tabSize": 2,
  "typescript.preferences.quoteStyle": "single",
  "typescript.format.semicolons": "remove",
  "javascript.preferences.quoteStyle": "single",
}

@imLymei

imLymei commented Dec 10, 2024

Copy link
Copy Markdown
Author

Hi! I changed some of the .prettierrc configuration to match the .vscode configuration, especially for two reasons:

  1. Even after opening the loader folder, the .vscode configuration did not change how Prettier formatted the pages.
  2. I know that a lot of people use Prettier, so instead of just disabling it, I think the better course of action is to make Prettier users' settings as close as possible to the .vscode configuration.

Of course, as mentioned before, all of these are merely suggestions. If you find it worse, I can just disable Prettier in this workspace.

Also, sorry for the delay. I haven't had much time on my hands lately.

@nomi-san

nomi-san commented Dec 10, 2024

Copy link
Copy Markdown
Member

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imLymei @nomi-san