Skip to content

Rename label: "Good first contribution" → "good first issue"#2004

Merged
namurphy merged 1 commit into
PlasmaPy:mainfrom
namurphy:update-good-first-issue-label
Mar 10, 2023
Merged

Rename label: "Good first contribution" → "good first issue"#2004
namurphy merged 1 commit into
PlasmaPy:mainfrom
namurphy:update-good-first-issue-label

Conversation

@namurphy

@namurphy namurphy commented Mar 9, 2023

Copy link
Copy Markdown
Member

This PR updates our documentation to refer to the "good first issue" label rather than the "Good first contribution" label. The reason is that "good first issue" has become the most common wording for this, and there are sites that look specifically for "good first issue" labels. So, it'd be helpful to update it for us too.

@codecov

codecov Bot commented Mar 9, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (8091c31) 98.33% compared to head (84bb3af) 98.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2004   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          96       96           
  Lines        8503     8503           
=======================================
  Hits         8361     8361           
  Misses        142      142           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@namurphy namurphy added the no changelog entry needed For PRs that should not have a changelog entry label Mar 9, 2023
@namurphy namurphy marked this pull request as ready for review March 9, 2023 22:47
@namurphy namurphy requested a review from a team as a code owner March 9, 2023 22:47
@namurphy namurphy requested review from pheuer and removed request for a team March 9, 2023 22:47

@ejohnson-96 ejohnson-96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all labels changed :)

@namurphy namurphy merged commit 4596712 into PlasmaPy:main Mar 10, 2023
@namurphy namurphy deleted the update-good-first-issue-label branch March 10, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog entry needed For PRs that should not have a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants