Skip to content

Use pip-compile to update requirements.txt#2013

Merged
namurphy merged 2 commits into
PlasmaPy:mainfrom
namurphy:update-requirements-2
Mar 14, 2023
Merged

Use pip-compile to update requirements.txt#2013
namurphy merged 2 commits into
PlasmaPy:mainfrom
namurphy:update-requirements-2

Conversation

@namurphy

@namurphy namurphy commented Mar 13, 2023

Copy link
Copy Markdown
Member

This PR does an update of requirements.txt using the command:

pip-compile --all-extras --output-file=requirements.txt --resolver=backtracking

This is in lieu of using dependabot for each one. The goal is to automate this in #1994.

@namurphy namurphy added the no changelog entry needed For PRs that should not have a changelog entry label Mar 13, 2023
@codecov

codecov Bot commented Mar 13, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (70505a7) 98.33% compared to head (31571e9) 98.33%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2013   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          96       96           
  Lines        8503     8503           
=======================================
  Hits         8361     8361           
  Misses        142      142

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@namurphy namurphy requested a review from ejohnson-96 March 13, 2023 19:11
@namurphy

namurphy commented Mar 13, 2023

Copy link
Copy Markdown
Member Author

Got these errors for the CI/Documentation build. Not sure what's causing them, but I'm wondering if re-running the notebooks will help.

/home/runner/work/PlasmaPy/PlasmaPy/docs/notebooks/diagnostics/charged_particle_radiography_film_stacks.ipynb: WARNING: "nbsphinx-thumbnail" in cell 19: Invalid "output-index": -1
/home/runner/work/PlasmaPy/PlasmaPy/docs/notebooks/diagnostics/charged_particle_radiography_particle_tracing.ipynb: WARNING: "nbsphinx-thumbnail" in cell 14: Invalid "output-index": -1
/home/runner/work/PlasmaPy/PlasmaPy/docs/notebooks/diagnostics/charged_particle_radiography_particle_tracing_custom_source.ipynb: WARNING: "nbsphinx-thumbnail" in cell 40: Invalid "output-index": -1

@review-notebook-app

review-notebook-app Bot commented Mar 13, 2023

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@namurphy namurphy marked this pull request as ready for review March 13, 2023 20:23
@namurphy namurphy requested review from a team and StanczakDominik as code owners March 13, 2023 20:23
@namurphy

namurphy commented Mar 13, 2023

Copy link
Copy Markdown
Member Author

@ejohnson-96 — this was the PR I mentioned earlier today, in case you had a chance to review it soon! It should be pretty straightforward.

namurphy
namurphy commented Mar 13, 2023
View reviewed changes
Comment thread docs/notebooks/diagnostics/charged_particle_radiography_film_stacks.ipynb
ejohnson-96
ejohnson-96 approved these changes Mar 14, 2023
View reviewed changes

@ejohnson-96 ejohnson-96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@namurphy namurphy merged commit 2decb70 into PlasmaPy:main Mar 14, 2023
@namurphy namurphy deleted the update-requirements-2 branch May 1, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejohnson-96 ejohnson-96 ejohnson-96 approved these changes
@StanczakDominik StanczakDominik Awaiting requested review from StanczakDominik

Assignees

No one assigned

Labels

no changelog entry needed For PRs that should not have a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@namurphy @ejohnson-96