Set the current location in PredictionClient when it's supported - #3639
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested review from
Patrick Meinecke (SeeminglyScience) and
Andy Jordan (andyleejordan)
March 27, 2023 23:05
13 tasks
Andy Jordan (andyleejordan)
approved these changes
Mar 28, 2023
Andy Jordan (andyleejordan)
left a comment
Member
There was a problem hiding this comment.
LGTM as long my reflection understanding is right.
Patrick Meinecke (SeeminglyScience)
approved these changes
Mar 29, 2023
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Member
Author
|
Thank both of you for the review! |
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Set the current location in
PredictionClientwhen it's supported.This is in accordance with PowerShell/PowerShell#19414, which adds the property
CurrentLocationtoPredictionClient, so as to make it easy for a predictor implementation to know the current location.PR Checklist
Microsoft Reviewers: Open in CodeFlow