Skip to content

Remove WorkflowJobSourceAdapter reference - #10326

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
KirkMunro:deprecate-workflow-job-source-adapter
Sep 17, 2019
Merged

Remove WorkflowJobSourceAdapter reference#10326
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
KirkMunro:deprecate-workflow-job-source-adapter

Conversation

@KirkMunro

Copy link
Copy Markdown
Contributor

PR Summary

This PR removes a reference to WorkflowJobSourceAdapter that is no longer used, as part of the workflow cleanup.

PR Context

See issue #9570.

PR Checklist

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Aug 8, 2019
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 9, 2019
@iSazonov Ilya (iSazonov) added this to the 7.0.0-preview.3 milestone Aug 9, 2019
@iSazonov Ilya (iSazonov) self-assigned this Aug 9, 2019
@iSazonov

Copy link
Copy Markdown
Collaborator

Paul Higinbotham (@PaulHigin) Please update your code review.

@KirkMunro

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) This PR is waiting for your review. All it does is remove an if clause related to workflow, replacing the entire if/else statement with the body of the else clause. No other code has changed, should be quick and easy.

@iSazonov

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Have you any thoughts about the PR?

@iSazonov
Ilya (iSazonov) merged commit ee8e4e0 into PowerShell:master Sep 17, 2019
@KirkMunro
Kirk Munro (KirkMunro) deleted the deprecate-workflow-job-source-adapter branch September 17, 2019 12:38
@ghost

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants