Refactor reparse tag checks - #10431
Conversation
|
Ilya (@iSazonov) did you test this manually for both OneDrive and AppX links? |
This reverts commit bf6912d.
|
Steve Lee (@SteveL-MSFT) I found a definition for name surrogate bit https://docs.microsoft.com/en-us/windows/win32/fileio/reparse-point-tags
|
|
Ilya (@iSazonov) did you confirm it works with OneDrive and AppX links? |
|
Steve Lee (@SteveL-MSFT) I can confirm only for AppX - I haven't OneDrive. |
|
Steve Lee (@SteveL-MSFT) Have you still any thoughts about the PR? |
Steve Lee (SteveL-MSFT)
left a comment
There was a problem hiding this comment.
I built your branch and tested it, looks good
|
🎉 Handy links: |
Reparse tag consts is absolute numbers, not flags so we should use a comparison instead of bit operations
PR Summary
Reparse tag consts is absolute numbers, not flags so we should use a comparison instead of bit operations
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.