Skip to content

Refactor reparse tag checks - #10431

Merged
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
iSazonov:refactor-reparse-tag-checks
Sep 17, 2019
Merged

Refactor reparse tag checks#10431
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
iSazonov:refactor-reparse-tag-checks

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Aug 23, 2019

Copy link
Copy Markdown
Collaborator

PR Summary

Reparse tag consts is absolute numbers, not flags so we should use a comparison instead of bit operations

PR Context

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Aug 23, 2019
@iSazonov Ilya (iSazonov) added this to the 7.0.0-preview.4 milestone Aug 23, 2019
@iSazonov Ilya (iSazonov) self-assigned this Aug 23, 2019
@SteveL-MSFT

Copy link
Copy Markdown
Member

Ilya (@iSazonov) did you test this manually for both OneDrive and AppX links?

@iSazonov

Ilya (iSazonov) commented Aug 25, 2019

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) I found a definition for name surrogate bit https://docs.microsoft.com/en-us/windows/win32/fileio/reparse-point-tags
So using 0x20000000 constant is correct and I reverted the change.
Now only comments is updated and fixed IO_REPARSE_TAG_APPEXECLINK comparison.

Each reparse point has an identifier tag so that you can efficiently differentiate between the different types of reparse points, without having to examine the user-defined data in the reparse point.

@SteveL-MSFT

Copy link
Copy Markdown
Member

Ilya (@iSazonov) did you confirm it works with OneDrive and AppX links?

@iSazonov

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) I can confirm only for AppX - I haven't OneDrive.

@iSazonov

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Have you still any thoughts about the PR?

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built your branch and tested it, looks good

@iSazonov
Ilya (iSazonov) merged commit 79e80a8 into PowerShell:master Sep 17, 2019
@iSazonov
Ilya (iSazonov) deleted the refactor-reparse-tag-checks branch September 17, 2019 05:48
@ghost

Copy link
Copy Markdown

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Reparse tag consts is absolute numbers, not flags so we should use a comparison instead of bit operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants