Skip to content

Change name of ClrVersion parameter back - #11623

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
rjmholt:restoreapi-clrversion
Jan 23, 2020
Merged

Change name of ClrVersion parameter back#11623
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
rjmholt:restoreapi-clrversion

Conversation

@rjmholt

Copy link
Copy Markdown
Collaborator

#9134 changed the ClrVersion parameter property on New-ModuleManifest to CLRVersion. To prevent portability issues with PowerShell tooling, this PR changes it back.

PR Context

See #11619.

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jan 18, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

What milestone we should set?

@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.1 milestone Jan 23, 2020
@iSazonov
Ilya (iSazonov) merged commit caa5051 into PowerShell:master Jan 23, 2020
@rjmholt

Copy link
Copy Markdown
Collaborator Author

What milestone we should set?

I’m away so haven’t been able to address this, but was targeting the 7.0 milestone, since this reverts a breaking change

@ghost

Copy link
Copy Markdown

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants