vscode: Enable EditorConfig support in OmniSharp - #11627
Conversation
Enable support for EditorConfig in OmniSharp. Since omnisharp-roslyn version 1.33.0, OmniSharp has had this support. * https://github.com/OmniSharp/omnisharp-roslyn/blob/master/CHANGELOG.md#1330---2019-07-01 * PowerShell#7357 * OmniSharp/omnisharp-roslyn#1526
Ilya (iSazonov)
left a comment
There was a problem hiding this comment.
LGTM.
I tried enableRoslynAnalyzers. It takes many time for analyzing and we need to adjust before enable.
|
Ilya (@iSazonov) I've used the |
|
My concern is that it takes a lot of computer resources. Perhaps we could enable subset of the analyzer to highlight our code conventions. |
|
Rain Sallow (/u/ta11ow) (@vexx32) I too am using Ilya (@iSazonov) Currently Omnisharp queues all documents in the solution for code analysis, rather than running on demand, so this uses a lot of resources when developing in vscode. |
|
xtqqczze Can we configure the code analysis? |
|
🎉 Handy links: |
PR Summary
Enable support for EditorConfig in OmniSharp.
PR Context
OmniSharp has this support since omnisharp-roslyn v1.33.0:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.