Skip to content

Add IDE analyzer rule IDs to comments - #13960

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:globalconfig-comments
Nov 2, 2020
Merged

Add IDE analyzer rule IDs to comments#13960
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:globalconfig-comments

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor

Follow-up to #13835.

@xtqqczze

xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Could you merge?

@xtqqczze

xtqqczze commented Nov 1, 2020

Copy link
Copy Markdown
Contributor Author

PowerShell-CI-static-analysis failure caused by transient network issues.

@kilasuit

Copy link
Copy Markdown
Collaborator

xtqqczze can you add a description to this PR as right now this to me doesn't explain why this should be merged, there is no link to an issue etc so there is no context to this PR other than what is in files changed - a recommended best practice for when raising a PR

@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.

@xtqqczze
xtqqczze force-pushed the globalconfig-comments branch from 3213040 to eb8c5c8 Compare November 2, 2020 03:48
@xtqqczze

xtqqczze commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) rebased, can you merge soon to avoid more merge conflicts

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 2, 2020
@iSazonov
Ilya (iSazonov) merged commit 329d6b4 into PowerShell:master Nov 2, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 2, 2020
@xtqqczze
xtqqczze deleted the globalconfig-comments branch November 2, 2020 10:18
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants