Skip to content

Fix IDE0044: MakeFieldReadonly part 11 - #13966

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0044-p11
Nov 7, 2020
Merged

Fix IDE0044: MakeFieldReadonly part 11#13966
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0044-p11

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044

Split from #13880 to ease review.

src\System.Management.Automation\engine\remoting\

src\System.Management.Automation\engine\remoting\
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 3, 2020
Comment thread src/System.Management.Automation/engine/remoting/client/Job.cs
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 3, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze Please look Paul Higinbotham (@PaulHigin)'s comments.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 6, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

Paul Higinbotham (@PaulHigin) Please update your review.

@PaulHigin

Copy link
Copy Markdown
Contributor

Ilya (@iSazonov) I'll approve once all requested changes are made.

@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze Please look new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants