Skip to content

Revert changes to ComInterop - #14012

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:revert-IDE0044-ComInterop
Nov 9, 2020
Merged

Revert changes to ComInterop#14012
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:revert-IDE0044-ComInterop

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 8, 2020

Copy link
Copy Markdown
Contributor

According to #13880 (comment) code in src/System.Management.Automation/engine/ComInterop/ comes from dotnet/runtime and should be frozen.

But in #13967 (part of #13880) we made changes to fix IDE0044: Add readonly modifier.

So this PR reverts these changes and disables code analyzers in this directory.

src/System.Management.Automation/engine/ComInterop/
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 9, 2020
@iSazonov
Ilya (iSazonov) merged commit ed595c0 into PowerShell:master Nov 9, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 9, 2020
@xtqqczze
xtqqczze deleted the revert-IDE0044-ComInterop branch November 9, 2020 14:17
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
* Revert changes to ComInterop

src/System.Management.Automation/engine/ComInterop/

* Disable code analysis in ComInterop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants