Skip to content

#4750 Fix Get-Date -UFormat %u behavior - #14549

Merged
Ilya (iSazonov) merged 4 commits into
PowerShell:masterfrom
brianary:UFormat_u
Feb 4, 2021
Merged

#4750 Fix Get-Date -UFormat %u behavior#14549
Ilya (iSazonov) merged 4 commits into
PowerShell:masterfrom
brianary:UFormat_u

Conversation

@brianary

@brianary Brian Lalonde (brianary) commented Jan 5, 2021 •
edited by iSazonov
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Corrects the behavior of %u in Get-Date -UFormat to match ISO 8601.

PR Context

This is to fix one of the format issues in #4750.

PR Checklist

@ghost

Deleted user (ghost) commented Jan 5, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@brianary

Brian Lalonde (brianary) commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

I can't really access the details, but the test failures appear to be unrelated.

@iSazonov Ilya (iSazonov) added Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Documentation Needed in this repo Documentation is needed in this repo labels Jan 6, 2021
iSazonov
Ilya (iSazonov) reviewed Jan 6, 2021
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Date.Tests.ps1 Outdated
Comment on lines 100 to 105

@iSazonov Ilya (iSazonov) Jan 6, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify how you select the test values (whole list)?

@brianary Brian Lalonde (brianary) Jan 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used the values from the previous test for %V, which is related, then added a couple recent dates that had led to discovering the bug. I'll add a comment to that effect, or else select some other dates.

@iSazonov Ilya (iSazonov) mentioned this pull request Jan 6, 2021
Closed
14 tasks
@ghost ghost added the Review - Needed The PR is being reviewed label Jan 14, 2021
@ghost

Deleted user (ghost) commented Jan 14, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@brianary

Brian Lalonde (brianary) commented Jan 15, 2021

Copy link
Copy Markdown
Contributor Author

Let me know if there's anything further I can provide.

@iSazonov Ilya (iSazonov) added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jan 15, 2021
@iSazonov

Ilya (iSazonov) commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Since it is a breaking change I ask PowerShell Committee to approve.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 15, 2021
@SteveL-MSFT Steve Lee (SteveL-MSFT) added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jan 20, 2021
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 20, 2021

Copy link
Copy Markdown
Member

@PowerShell/powershell-committee reviewed this, we agreed that this is a bug that should be fixed and this is likely a bucket 3 compatibility issue.

@brianary

Brian Lalonde (brianary) commented Jan 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) should #14555 also be taken with this one, since they are so tightly related?

@iSazonov

Ilya (iSazonov) commented Jan 25, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Please create new issue in PowerShell-Doc repository and add a reference to the issue in the PR description.

@brianary Brian Lalonde (brianary) mentioned this pull request Jan 26, 2021
Closed
@ghost

Deleted user (ghost) commented Feb 2, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost added the Review - Needed The PR is being reviewed label Feb 2, 2021
rjmholt
Rob Holt (rjmholt) approved these changes Feb 2, 2021
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Outdated
@iSazonov

Ilya (iSazonov) commented Feb 3, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Please rebase. I hope after that CI-Windows will pass.

@ghost ghost removed the Review - Needed The PR is being reviewed label Feb 3, 2021
@brianary @rjmholt @BrianL-STCU
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Get…
c7df635 
…DateCommand.cs

Co-authored-by: Robert Holt <rjmholt@gmail.com>
@iSazonov Ilya (iSazonov) removed the Documentation Needed in this repo Documentation is needed in this repo label Feb 4, 2021
@iSazonov
Ilya (iSazonov) merged commit 61fea6c into PowerShell:master Feb 4, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Feb 4, 2021
@iSazonov

Ilya (iSazonov) commented Feb 4, 2021

Copy link
Copy Markdown
Collaborator

Brian Lalonde (@brianary) Thanks for your contribution!

@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@brianary
PowerShell#4750 Fix Get-Date -UFormat %u behavior (PowerShell#14549)
8d24101 
Corrects a behavior of %u in Get-Date -UFormat to match ISO 8601.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

5 participants

@brianary @iSazonov @SteveL-MSFT @rjmholt @BrianL-STCU