Update ControlSequenceLength to handle colon VT param separators - #14942
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoMay 6, 2021
Merged
Conversation
The ControlSequenceLength function calculates the length of a VT control sequence--used by LengthInBufferCells. SGR control sequences might have parameters, separated by semicolons... or possibly colons. See: microsoft/terminal#4321 This change updates ControlSequenceLength to treat colons similarly to semicolons.
Dan Thompson (jazzdelightsme)
requested review from
Andrew (anmenaga) and
Dongbo Wang (daxian-dbw)
as code owners
March 4, 2021 06:36
Collaborator
|
/azp run PowerShell-CI-static-analysis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Member
|
/azp run PowerShell-CI-static-analysis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Dongbo Wang (daxian-dbw)
approved these changes
May 6, 2021
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ControlSequenceLength function calculates the length of a VT control
sequence--used by LengthInBufferCells. SGR control sequences might have
parameters, separated by semicolons... or possibly colons. See:
microsoft/terminal#4321
This change updates ControlSequenceLength to treat colons similarly to
semicolons.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).