Move cross platform DSC code to a subsystem - #15127
Move cross platform DSC code to a subsystem#15127Aditya Patwardhan (adityapatwardhan) merged 19 commits into
Conversation
Why not move the old code too? |
|
Ilya (@iSazonov) old code is planned to be removed completely by a separate PR. |
And the experimental "PS7DscSupport" flag too? Release will contain only new code?
Private repo? Is a plan to make public? |
|
Will this be backported anywhere? |
The current plan is: "yes" to both questions.
Yes, the plan is to make it public. |
Good question; At this point I don't see a strong reason for backporting, considering GC is happy as it currently is without the backport. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
|
Andrew (@anmenaga) Please resolve merge conflicts. |
|
Andrew (@anmenaga) Please respond to comment from Dongbo: #15127 (comment) |
|
Updated according to offline discussion with Dongbo and Steve. Dongbo Wang (@daxian-dbw) can you please have another look? Thank you. |
|
Andrew (@anmenaga) Great work! |
|
🎉 Handy links: |
PR Summary
This work is in the context of Minimal PowerShell.
Cross platform DSC code that was in
System.Management.Automation.dllis extracted as a PowerShell subsystem (this PR) and moved to a newMicrosoft.PowerShell.DscSubsystem.dllto be shipped withPSDesiredStateConfigurationv3 module (PR in PSDesiredStateConfiguration repo).PR Context
This PR is following guidelines from subsystem architecture document:
System.Management.Automation.dlland placed into a newMicrosoft.PowerShell.DscSubsystem.dllinPSDesiredStateConfigurationv3 module.ICrossPlatformDscis defined in SMA and implemented inMicrosoft.PowerShell.DscSubsystem.dllIModuleAssemblyInitializer.OnImport(implemented inMicrosoft.PowerShell.DscSubsystem.dll) whenPSDesiredStateConfigurationv3 module is loaded.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).