Skip to content

Revert "Enhance Remove-Item to work with OneDrive (#14902)" - #15253

Merged
Travis Plunk (TravisEz13) merged 1 commit into
masterfrom
daily-issue-20210416
Apr 16, 2021
Merged

Revert "Enhance Remove-Item to work with OneDrive (#14902)"#15253
Travis Plunk (TravisEz13) merged 1 commit into
masterfrom
daily-issue-20210416

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Apr 16, 2021

Copy link
Copy Markdown
Member

PR Summary

We have been having issues with Remove-Item -Recure -Force failing since fafc38f.

So, reverting that commit until the issue has been addressed.

PR Context

https://dev.azure.com/powershell/PowerShell/_build/results?buildId=76645&view=logs&j=719313b2-5d75-51d7-9f16-928d568dcba1&t=51cacb73-0bf2-5113-ddc2-bada8ccfae1e&l=114

Tests were failing with:

 Describing About help files can be found in AllUsers scope 
 [-] Error occurred in Describe block 0ms 
 IOException: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\' 
 IOException: Cannot remove item C:\Users\VssAdministrator\Documents\PowerShell\Help\: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\' 
 at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\HelpSystem.Tests.ps1: line 267 
 at Invoke-Blocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 135 
 at Invoke-TestGroupSetupBlocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 121 
 at DescribeImpl, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\Describe.ps1: line 209 

PR Checklist

@TravisEz13

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@TravisEz13

Copy link
Copy Markdown
Member Author

/azp list

@azure-pipelines

Copy link
Copy Markdown

@TravisEz13

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@TravisEz13

This comment has been minimized.

@TravisEz13

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@TravisEz13

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@TravisEz13

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@TravisEz13

Copy link
Copy Markdown
Member Author

/azp run PowerShell-CI-Windows-daily

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13
Travis Plunk (TravisEz13) merged commit 720c615 into master Apr 16, 2021
@TravisEz13
Travis Plunk (TravisEz13) deleted the daily-issue-20210416 branch April 16, 2021 20:43
@rjmholt

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) #14902 caused an issue with Remove-Item, forcing us to revert it:

  Describing About help files can be found in AllUsers scope
    [-] Error occurred in Describe block 0ms
      IOException: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\'
      IOException: Cannot remove item C:\Users\VssAdministrator\Documents\PowerShell\Help\: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\'
      at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\HelpSystem.Tests.ps1: line 267
      at Invoke-Blocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 135
      at Invoke-TestGroupSetupBlocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 121
      at DescribeImpl, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\Describe.ps1: line 209

if (ExperimentalFeature.IsEnabled("PSAnsiRendering"))
{
PSStyle psstyle = PSStyle.Instance;
PSStyle psstyle = PSStyle.Instance;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra white space?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will remove in follow PR.

@iSazonov

Copy link
Copy Markdown
Collaborator

I wonder how was CIs passed in the PR. Should we fix anything in CIs?

@TravisEz13

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) No the daily CI run serially. You should open a new PR and fix the issue in the remove-item code.

Keith Hill (rkeithhill) pushed a commit to rkeithhill/PowerShell that referenced this pull request May 3, 2021
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 26, 2021
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants