Remove unneeded SSH remoting std handle workaround - #15308
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoApr 30, 2021
Conversation
Paul Higinbotham (PaulHigin)
requested review from
Steve Lee (SteveL-MSFT) and
Ilya (iSazonov)
and removed request for
Steve Lee (SteveL-MSFT)
April 26, 2021 16:26
Ilya (iSazonov)
left a comment
Collaborator
There was a problem hiding this comment.
Make sense to add a test?
Contributor
Author
|
No new tests are needed for this. |
Ilya (iSazonov)
approved these changes
Apr 29, 2021
Keith Hill (rkeithhill)
pushed a commit
to rkeithhill/PowerShell
that referenced
this pull request
May 3, 2021
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR removes an unneeded SSH remoting .NET std stream workaround. Issue #15229.
PR Context
In the early days .NET stream reader/writer did not correctly handle std streams on Windows plaforms only, and we had a PInvoke workaround. This workaround is no longer needed and can be removed. This change also disables the ability for Console APIs to write to stdout, which is reserved for PSRP messages only.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).