Fix the build when using PSDesiredStateConfiguration module from PS Gallery - #15355
Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits intoMay 5, 2021
Merged
Conversation
Andrew (anmenaga)
requested review from
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
as code owners
May 5, 2021 18:46
Travis Plunk (TravisEz13)
requested changes
May 5, 2021
| </Component> | ||
| </Directory> | ||
| <Component Id="cmp67C4A6FC5E48487BB31DE411CF38B0B2"> | ||
| <File Id="fil747B2801746E4FFCB93000BBA1089F15" KeyPath="yes" Source="$(var.ProductSourcePath)\Modules\PSDesiredStateConfiguration\PSDesiredStateConfiguration.cat" /> |
There was a problem hiding this comment.
Revert this change and let the code generate the update and check that in.
Travis Plunk (TravisEz13)
approved these changes
May 5, 2021
Aditya Patwardhan (adityapatwardhan)
approved these changes
May 5, 2021
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The build is now using the PSDesiredStateConfiguration module from PS Gallery but has a check for a catalog file which is no longer there. This PR removes the check.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).