Skip to content

Enhance Remove-Item to work with OneDrive (Third) - #15571

Merged
Rob Holt (rjmholt) merged 11 commits into
PowerShell:masterfrom
iSazonov:isreparsepointlikesymlink3
Aug 5, 2021
Merged

Enhance Remove-Item to work with OneDrive (Third)#15571
Rob Holt (rjmholt) merged 11 commits into
PowerShell:masterfrom
iSazonov:isreparsepointlikesymlink3

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Jun 13, 2021

Copy link
Copy Markdown
Collaborator

PR Summary

Fix #15466

Continue #15260

EnsureExtendedPrefix is copy-pasted from .Net Runtime repository.

PR Context

PR Checklist

Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
@iSazonov

Copy link
Copy Markdown
Collaborator Author

Rob Holt (@rjmholt) Friendly ping :-)

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 25, 2021
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/utils/PathUtils.cs Outdated
Comment thread src/System.Management.Automation/utils/PathUtils.cs Outdated
Comment thread src/System.Management.Automation/utils/PathUtils.cs Outdated
@iSazonov
Ilya (iSazonov) force-pushed the isreparsepointlikesymlink3 branch from 35ebe2c to b28f930 Compare July 27, 2021 06:04
@rjmholt

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) please add comments around code that's been copy/pasted from .NET about where it's come from

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 27, 2021
@iSazonov

Copy link
Copy Markdown
Collaborator Author

Ilya (@iSazonov) please add comments around code that's been copy/pasted from .NET about where it's come from

There is already #region Helpers for long paths from .Net Runtime.

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 4, 2021
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt

Copy link
Copy Markdown
Collaborator

/azp run

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 5, 2021
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 6 pipeline(s).

Comment thread src/System.Management.Automation/utils/PathUtils.cs
Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Co-authored-by: Steve Lee <slee@microsoft.com>
Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Comment thread src/System.Management.Automation/engine/Utils.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Co-authored-by: Steve Lee <slee@microsoft.com>
@rjmholt

Copy link
Copy Markdown
Collaborator

PoshChan-Bot (@PoshChan) please remind me in 1 hour

@rjmholt
Rob Holt (rjmholt) enabled auto-merge (squash) August 5, 2021 17:39
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
Comment thread src/System.Management.Automation/namespaces/FileSystemProvider.cs Outdated
@PoshChan

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt), this is the reminder you requested 1 hour ago

@rjmholt
Rob Holt (rjmholt) merged commit 45adfee into PowerShell:master Aug 5, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@iSazonov
Ilya (iSazonov) deleted the isreparsepointlikesymlink3 branch August 5, 2021 18:46
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove-Item does not work correctly with long paths

6 participants