Skip to content

Update the mdspell command to exclude the folder that should be ignored - #15576

Merged
Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
daxian-dbw:mdspell
Jun 15, 2021
Merged

Update the mdspell command to exclude the folder that should be ignored#15576
Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
daxian-dbw:mdspell

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

PR Summary

Update the mdspell command to ignore the test/perf folder.

PR Checklist

@rjmholt

Copy link
Copy Markdown
Collaborator

Isn't that folder just ordinary markdown in our repo? Why does it need to be excluded?

@daxian-dbw

Copy link
Copy Markdown
Member Author

That folder contains files copied from dotnet/performance, including the markdown files, and we will have to sync with dotnet/performance from time to time.

@rjmholt

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw) might be worth adding that as a comment above the invocation so we know why we have that specific exclusion

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jun 15, 2021

Copy link
Copy Markdown
Member Author

Narrow down the excluded folder to just dotnet-tools and add a comment to explain why.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 6833b2a into PowerShell:master Jun 15, 2021
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the mdspell branch June 15, 2021 20:31
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 15, 2021
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants