Fix unixmode to handle setuid/sticky when not executable - #20366
Merged
Dongbo Wang (daxian-dbw) merged 9 commits intoOct 11, 2023
Merged
Fix unixmode to handle setuid/sticky when not executable#20366Dongbo Wang (daxian-dbw) merged 9 commits into
Dongbo Wang (daxian-dbw) merged 9 commits into
Conversation
James Truher (JamesWTruher)
force-pushed
the
UnixModeStringFix01
branch
from
October 2, 2023 23:24
ff2c2b3 to
310c4d5
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Ilya (iSazonov)
approved these changes
Oct 3, 2023
Dongbo Wang (daxian-dbw)
requested changes
Oct 11, 2023
…at.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
Use stackalloc rather than new for character mode array.
…onstants." This reverts commit 22769e9cd46bfc3620f96081e3b3783fa4e2d485.
Use stackalloc rather than new for character mode array.
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
James Truher (JamesWTruher)
force-pushed
the
UnixModeStringFix01
branch
from
October 11, 2023 23:15
830080b to
00a4b6e
Compare
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
James Truher (JamesWTruher)
force-pushed
the
UnixModeStringFix01
branch
from
October 11, 2023 23:22
00a4b6e to
70292b0
Compare
Dongbo Wang (daxian-dbw)
enabled auto-merge (squash)
October 11, 2023 23:29
Contributor
|
📣 Hey James Truher (@JamesWTruher), how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://forms.office.com/r/P926k48jRJ |
5 tasks
Aditya Patwardhan (adityapatwardhan)
pushed a commit
that referenced
this pull request
Oct 19, 2023
Aditya Patwardhan (adityapatwardhan)
added a commit
that referenced
this pull request
Oct 19, 2023
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a fix for #20278
PR Context
I'm not addressing the CodeFactor reported complexity as I don't believe this method is overly complicated.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).