Add telemetry to check for specific tags when importing a module - #20371
Merged
Dongbo Wang (daxian-dbw) merged 3 commits intoOct 16, 2023
Merged
Conversation
James Truher (JamesWTruher)
requested review from
Steve Lee (SteveL-MSFT) and
Travis Plunk (TravisEz13)
September 26, 2023 18:42
Steve Lee (SteveL-MSFT)
requested changes
Sep 26, 2023
James Truher (JamesWTruher)
force-pushed
the
TelemetryModuleTag01
branch
from
October 3, 2023 22:05
8106dd6 to
6ac4c01
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This allows us to more easily add tags in the future if we need it.
James Truher (JamesWTruher)
force-pushed
the
TelemetryModuleTag01
branch
from
October 11, 2023 22:10
35bf161 to
19fe57e
Compare
Steve Lee (SteveL-MSFT)
approved these changes
Oct 11, 2023
Contributor
|
📣 Hey James Truher (@JamesWTruher), how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://forms.office.com/r/P926k48jRJ |
Aditya Patwardhan (adityapatwardhan)
pushed a commit
that referenced
this pull request
Oct 19, 2023
Aditya Patwardhan (adityapatwardhan)
added a commit
that referenced
this pull request
Oct 19, 2023
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We would like to be able to determine whether Crescendo is being used by tracking module import and see whether the the
CrescendoBuilttag has been applied to the module. This PR generalizes the tag inspection so we can add additional tags in the future.we also need to add this to the document which describes what telemetry we collect.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).