Skip to content

Only register App Path for release package - #20478

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
heaths:issue20374
Oct 16, 2023
Merged

Only register App Path for release package#20478
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
heaths:issue20374

Conversation

@heaths

@heaths Heath Stewart (heaths) commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Resolves #20374

@heaths

Heath Stewart (heaths) commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

The change to the component ID won't matter. Only component GUIDs matter, which in WiX are based on any parent context (which didn't change) and the key path (which also didn't change), as you can see here comparing my installed release PowerShell, a "release" MSI I built, and a preview MSI I built (from back to fore):

image

Also of note: Travis Plunk (@TravisEz13), should Start-PSPackage -SkipReleaseCheck skip the BOM check? Steve Lee (@SteveL-MSFT) had to give me a lot of help to get the MSI built (I forgot some initially; other cases were non-obvious errors to me). Seems checking the BOM is more of a release activity.

@heaths Heath Stewart (heaths) changed the title Only registry App Path for release package Only register App Path for release package Oct 11, 2023
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Oct 11, 2023
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best I can tell, LGTM

@heaths

Heath Stewart (heaths) commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

I'm looking into the test failure now, but you might have a CI script problem as well:

Tests completed in 524.18s
Tests Passed: 1449, Failed: 1, Skipped: 13, Pending: 66, Inconclusive: 0 
Result Attachments will be stored in LogStore
Run Attachments will be stored in LogStore
The input object cannot be bound to any parameters for the command either because the command does not take pipeline input or the input and its properties do not match any of the parameters that take pipeline input.1 tests in test/powershell failed
At D:\a\1\s\build.psm1:1813 char:13
+             throw "$($x.'test-results'.failures) tests in $TestArea f …
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : OperationStopped: (1 tests in test/powershell failed:String) [], RuntimeException
+ FullyQualifiedErrorId : 1 tests in test/powershell failed
Publishing test results to test run '2143526'.

@heaths

Heath Stewart (heaths) commented Oct 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Looks like the test error is probably unrelated, but I'll try rerunning it in case it's ephemeral.

Failed: Set/New/Remove-Service cmdlet tests.Remove-Service can remove a service
Error message: Expected $null or empty, but got @(System.ServiceProcess.ServiceControll
Stack trace:
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Management\Set-Service.Tests.ps1: line 279
279:             $service | Should -BeNullOrEmpty

EDIT: Looks like I can't rerun failed tests from either in GitHub via the Checks tab, nor in Azure DevOps (no permissions).

@iSazonov

Ilya (iSazonov) commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

Restart CI-Windows...

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 16, 2023
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw Dongbo Wang (daxian-dbw) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.4.x-Consider labels Oct 16, 2023
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 5272720 into PowerShell:master Oct 16, 2023
Merged
Aditya Patwardhan (adityapatwardhan) pushed a commit that referenced this pull request Oct 20, 2023
@heaths @adityapatwardhan
Only registry App Path for release package (#20478)
5dc5422
Aditya Patwardhan (adityapatwardhan) added a commit that referenced this pull request Oct 20, 2023
@adityapatwardhan @heaths
Only registry App Path for release package (#20478) (#20549)
0baa5b4 
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@heaths
Only registry App Path for release package (PowerShell#20478)
bb12df2
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan @heaths
Only registry App Path for release package (PowerShell#20478) (PowerS…
55bc4d4 
…hell#20549)

Co-authored-by: Heath Stewart <heaths@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

Backport-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

6 participants

@heaths @iSazonov @daxian-dbw @SteveL-MSFT @TravisEz13 @adityapatwardhan