Skip to content

Fix Copy-Item progress to only show completed when all files are copied - #20517

Merged
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
SteveL-MSFT:copy-single-progress
Oct 19, 2023
Merged

Fix Copy-Item progress to only show completed when all files are copied#20517
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
SteveL-MSFT:copy-single-progress

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Oct 18, 2023

Copy link
Copy Markdown
Member

PR Summary

The previous code was always completing the progress between file copies so if you're just copying a folder of files, then the progress gets cleared quickly or before it shows so it appears that no progress is rendering. Fix is to only complete the progress if all the files have been copied.

PR Context

Fix #19600

PR Checklist

@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title Remove unnecessary clearing of progress for Copy-Item for files Fix Copy-Item progress to only show completed when all files are copied Oct 19, 2023
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 581ee20 into PowerShell:master Oct 19, 2023
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the copy-single-progress branch October 19, 2023 18:01
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Backport-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed Backport-7.4.x-Approved labels Oct 19, 2023
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copy progress in 7.4 preview 3 does not work if files are in a single directory and does not show correct total to copy

2 participants