[release/v7.7.0-preview.1] PMC release: Use slash instead of back-slash for Linux container#27375
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Backport to release/v7.7.0-preview.1 to fix CredScan in the PMC release pipeline when running in Linux containers by using Linux-compatible path separators for the CredScan suppressions file.
Changes:
- Update
ob_sdl_credscan_suppressionsFileto use forward slashes (/) instead of backslashes (\) in the suppressions file path.
f1327fb
into
PowerShell:release/v7.7.0-preview.1
39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27315 to release/v7.7.0-preview.1
Triggered by @jshigetomi on behalf of @daxian-dbw
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Fixes CredScan failure in PMC release pipeline on Linux containers by using forward slashes instead of backslashes in the suppress.json path.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Verified by original PR and successful merges to v7.4.15, v7.5.6, and v7.6.1 release branches. The fix corrects a path separator that caused CredScan to fail on Linux containers.
Risk
REQUIRED: Check exactly one box.
Low risk — single character change (backslash to forward slash) in a pipeline YAML path variable; same fix already merged to v7.4, v7.5, and v7.6 release branches.
Merge Conflicts
Conflict in .pipelines/templates/release-prep-for-ev2.yml: The release branch had an additional ob_sdl_tsa_configFile variable not present on master. Resolution: applied the backslash-to-forward-slash fix for ob_sdl_credscan_suppressionsFile and preserved the extra ob_sdl_tsa_configFile variable from the release branch.